chore(deps): Update Go SDK to v1.61.0 [WIP]#4452
chore(deps): Update Go SDK to v1.61.0 [WIP]#4452krishnamd-jkp wants to merge 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, primarily upgrading the Go language version and several key Google Cloud Go SDK modules. This ensures the project remains current with the latest library versions, benefiting from performance improvements, bug fixes, and new features provided by these updates, without introducing any explicitly backward incompatible changes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several Go dependencies, including upgrading the Go version to 1.25.0. While most dependency updates appear to be routine, I've identified a critical issue with the version specified for cloud.google.com/go/storage. The pseudo-version used contains a timestamp from the future, which is invalid and likely an error. This could lead to problems with dependency resolution and builds. Please see my specific comment for details and a suggested fix.
ec53b31 to
e8f62d0
Compare
| @@ -1,6 +1,6 @@ | |||
| module github.com/googlecloudplatform/gcsfuse/v3 | |||
|
|
|||
| go 1.24.11 | |||
There was a problem hiding this comment.
We are currently in the process of upgrading to Golang 1.26. Would it be possible to release a Golang 1.24 compatible library?
There was a problem hiding this comment.
We have upgraded the Go SDK recently to 1.25.0 so I'm afraid the only option is to cherry pick these changes onto a different release branch without the go upgrade commit which is not the cleanest way.
Description
Pre-release PR for cloud.google.com/go/storage update to v1.61.0
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.