Add support for bidirectional streaming within eval service.#370
Open
erinlimbogoogle wants to merge 3 commits intomainfrom
Open
Add support for bidirectional streaming within eval service.#370erinlimbogoogle wants to merge 3 commits intomainfrom
erinlimbogoogle wants to merge 3 commits intomainfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
IsmailMehdi
reviewed
May 5, 2026
|
|
||
| message EvalInputRequest { | ||
| int64 id = 1; | ||
| string conversation_id = 18; |
Collaborator
There was a problem hiding this comment.
should be sorted by id
| string sql_generator_error = 12; | ||
| float sql_generator_time = 13; | ||
| string generated_sql = 14; | ||
| string generated_nl_response = 19; |
|
|
||
| finally: | ||
| # Clean up the global registry to prevent memory leaks. | ||
| PROXY_QUEUES.pop(session_id, None) |
Collaborator
There was a problem hiding this comment.
If a client connection drops forcefully or hangs, and the Interact RPC does not hit its finally block cleanup (or if the thread hangs indefinitely
blocked on inbound_response = thread_inbox.get(block=True, timeout=300.0) ), then that entry in PROXY_QUEUES will leak and remain in memory even
after the background reaper deletes the session from Disk/SessionManager!
we should clear it when the session gets deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.