Merged
Conversation
On Windows and Linux, console.log() writes to a non-blocking stdout buffer. The previous setTimeout(() => process.exit(0), 3000) could force-terminate the process before the buffer was flushed, causing Claude to receive an empty path and skip the MEDIA delivery step. Two fixes: 1. Replace console.log + setTimeout/exit with process.stdout.write(path, callback) so the rest of the logic only runs after stdout is confirmed flushed. 2. Use process.exitCode = 0 instead of process.exit() to let Node drain all pending I/O naturally. Also fix Windows browser open: 'start ""' is a cmd.exe built-in and must be called as 'cmd /c start ""' when spawned via child_process.exec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without .unref(), if exec child process (xdg-open, cmd /c start) hangs, Node would never exit naturally and the 3s setTimeout would be the only exit path — but only if it keeps the event loop alive. With .unref(), the timer does not prevent natural exit but still fires as a hard fallback if exec blocks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief description of the changes.
Type
Testing
npm run buildpassesnpm testpasses (32 tests)Related Issues
Closes #