Dynamic loading of new peers using inotify#3
Open
as-j wants to merge 3 commits intoGetaround:masterfrom
Open
Conversation
Before a SIGHUP could be sent to the process, but this caused fastd to spend 2-3 minutes reloading config files when there are 10,000 peers. This allows it to load a file at a time when new keys are copied over.
scubafish
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to reload all peers, and when you have 12k of them this can take 30s while it happens, and blocks all traffic while in progress.