You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I must admit that I have doubts about this patch. Namely, there
is already a flag, namely 'l_flag' that controls printing of
files. Extra machinery, that is 'cucharverbose' to control
the same thing looks undesirable (unnecessary complexity).
I think it would be better to to set 'l_flag' to false to
get the effect.
Of course, there is a difficulty: option processing may set
'l_flag' to true after '-quiet' set it to false. One solution,
which is simple is to set 'l_flag' only due to explicit request
(that is '-l' option). Another is to change '-quiet' handling to
elseif c == "quiet" then
false -> popgctrace;
"quiet" -> l_flag;
and assign 'l_flag or true' to 'l_flag' during option processing.
And at end add
if l_flag == "quiet" then false -> l_flag endif;
Or, set extra variable during processing of 'quiet' and if that
variable is set assign 'false' to 'l_flag'.
Concerning build: I agree that by default it should less chatty,
but IMO this should be controlled by variable, so that one
can turn on verbosity from command line.
BTW: For build I usually use commands like
make > mlogg 2>&1
If everything goes OK I can discard 'mlogg' later. In case
of troubles verbosity may help...
I agree that using the preexisting l_flag is a less intrusive change and I have adopted Waldek's suggestion almost in its entirety. The suggestion that the verbosity should be controlled by a variable I have not followed through for these reasons.
It is unclear whether the intention is an environment variable or a pop11 variable (e.g. some variant on pop_debugging) .
If there is a -l flag to generate a listing then it makes sense for there to be a -q flag to inhibit the listing. To my way of thinking it is a pretty clear omission in the design of the option flags.
It should be easy enough to incorporate this suggestion when it is clarified.
: Concerning build: I agree that by default it should less chatty,
: but IMO this should be controlled by variable, so that one
: can turn on verbosity from command line.
This is not about popc. Rather I mean Makefiles for Poplog build.
And by variable I mean make variable.
Concerning patches, I have two remarks:
As is last of -q and -l wins. I am not sure if this is useful. Code would be
simpler if -q always wins. This is minor issue, I mention this to make sure
that you really want this.
In my code I am trying to keep line length below 80 characters. Your
comments creates longer lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new flag '-quiet' to the popc compiler that suppresses the garbage collection message and also the printing of file names to stderr.