Skip to content

Remove eager DB access in proxy AppConfig.ready() #14121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −18
Draft

Remove eager DB access in proxy AppConfig.ready() #14121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
776a32b
Initial plan
Copilot Apr 9, 2026
7592eb5
Fix proxy warning at boot time by removing DB access during app initi…
Copilot Apr 9, 2026
c833e73
Move utils import to module level in apps.py per code review feedback
Copilot Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions geonode/proxy/apps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,9 @@
#
#########################################################################
from django.apps import AppConfig
from django.db.models.signals import post_migrate
from django.db.models import signals

from .utils import proxy_urls_registry


def run_setup_hooks(*args, **kwargs):
proxy_urls_registry.initialize()
from .utils import link_post_delete, link_post_save


class GeoNodeProxyAppConfig(AppConfig):
Expand All @@ -32,8 +28,7 @@ class GeoNodeProxyAppConfig(AppConfig):

def ready(self):
super().ready()
try:
run_setup_hooks()
except Exception:
# This is in case the Service table doesn't exist yet
post_migrate.connect(run_setup_hooks, sender=self)
from geonode.base.models import Link

signals.post_save.connect(link_post_save, sender=Link)
signals.post_delete.connect(link_post_delete, sender=Link)
7 changes: 0 additions & 7 deletions geonode/proxy/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from urllib.parse import urlsplit

from django.conf import settings
from django.db.models import signals
from django.utils.timezone import now

site_url = urlsplit(settings.SITEURL)
Expand All @@ -10,7 +9,6 @@


class ProxyUrlsRegistry:
_first_init = True
_last_registry_load = None
_registry_reload_threshold = getattr(settings, "PROXY_RELOAD_REGISTRY_THRESHOLD_DAYS", 1)

Expand All @@ -27,11 +25,6 @@ def initialize(self):
remote_host = urlsplit(link.url).hostname
self.register_host(remote_host)

if self._first_init:
signals.post_save.connect(link_post_save, sender=Link)
signals.post_delete.connect(link_post_delete, sender=Link)
self._first_init = False

self._last_registry_load = now()

def set(self, hosts):
Expand Down