Skip to content

Add resourcehandlerinfo creation management command#14118

Open
mattiagiupponi wants to merge 2 commits intomasterfrom
resource_handlerinfo_fix
Open

Add resourcehandlerinfo creation management command#14118
mattiagiupponi wants to merge 2 commits intomasterfrom
resource_handlerinfo_fix

Conversation

@mattiagiupponi
Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy April 9, 2026 10:14
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 9, 2026
@mattiagiupponi mattiagiupponi linked an issue Apr 9, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Django management command, fixup_resourcehandlerinfo.py, designed to generate missing ResourceHandlerInfo for Dataset objects based on their subtype. It also updates the 0046_dataset_migration.py to incorporate similar logic for datasets that lack associated files. The review identifies a critical issue in both the new command and the migration: the handler_module_path is incorrectly set using the string representation of a handler instance rather than its proper class module path, which could lead to incorrect behavior. Furthermore, the logging configuration in the new management command is noted as an area for improvement, as it directly modifies the root logger, potentially causing conflicts with Django's default logging setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.0.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResourceHandlerInfo is not always managed

2 participants