[Fixes #14107] Add configurable sync strategies for Social Account group memberships#14108
Open
[Fixes #14107] Add configurable sync strategies for Social Account group memberships#14108
Conversation
Gpetrak
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable synchronization strategy for user groups during social login, allowing for full, safe, or no synchronization via the SOCIALACCOUNT_SYNC_USER_GROUPS_ON_LOGIN setting. A potential logic error was identified in the SAFE_SYNC mode where an empty group list from the provider could cause the synchronization to skip entirely instead of clearing existing local groups.
mattiagiupponi
requested changes
Apr 10, 2026
| } | ||
|
|
||
| # Default to FULL_SYNC to maintain backward compatibility | ||
| SOCIALACCOUNT_SYNC_USER_GROUPS_ON_LOGIN = os.getenv("SOCIALACCOUNT_SYNC_USER_GROUPS_ON_LOGIN", "FULL_SYNC") |
Contributor
There was a problem hiding this comment.
i would add here as a comment the three possibility and what they actually do
| groups = extractor.extract_groups(sociallogin.account.extra_data) | ||
|
|
||
| # If groups are missing, try roles | ||
| if groups == "": |
Contributor
There was a problem hiding this comment.
maybe if not groups is better, so if the code change and returns False / None or [] here is still compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created according to this issue: #14107
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.