Skip to content

[Fixes #14095] Upload thumbnails through the UI for the remote spatial datasets#14096

Open
sijandh35 wants to merge 3 commits intomasterfrom
ISSUE_14095
Open

[Fixes #14095] Upload thumbnails through the UI for the remote spatial datasets#14096
sijandh35 wants to merge 3 commits intomasterfrom
ISSUE_14095

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14095

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the set_thumbnail method in geonode/resource/manager.py to allow thumbnail assignment when a thumbnail is explicitly provided, regardless of the resource's default capabilities. The review feedback suggests refining the conditional logic to better handle falsy thumbnail values and avoid unintended automatic generation for resources that do not support it.

@sijandh35 sijandh35 requested a review from mattiagiupponi April 3, 2026 14:23
@mattiagiupponi mattiagiupponi requested review from Gpetrak and mattiagiupponi and removed request for mattiagiupponi April 3, 2026 16:08
) -> bool:
_resource = instance or BaseResourceManager._get_instance(uuid)
if _resource and _resource.can_have_thumbnail:
if _resource and (thumbnail or _resource.can_have_thumbnail):
Copy link
Copy Markdown
Member

@Gpetrak Gpetrak Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sijandh35 although the fix works fine, we could further improve the code in terms of sustainability and readability.
At first I would rename the property from can_have_thumbnail to the can_set_thumbnail and I would move the logic there as below:

def can_set_thumbnail(self, thumbnail_data=None):
    """
   a simple description
    """
    if thumbnail_data:
        return True
    
    # a comment for clarification
    return self.subtype not in {"3dtiles", "cog", "flatgeobuf"}

and then in the manager we could simply have:

if _resource and _resource.can_set_thumbnail(thumbnail):

As I saw the property can_have_thumbnail is used only in this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users are not able to upload thumbnails through the UI for the remote spatial datasets

3 participants