[Backport 5.1.x] Fix #2515 Only WMS maplayers are persisted correctly in the resource payload (#2517)#2530
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors dataset resource data handling by introducing a nested structure for layer settings and map configurations. It updates the API, epics, reducers, and selectors to ensure map state and projection settings are correctly persisted during transitions. The map zooming logic was also updated to defer execution until the map plugin mounts. A review comment correctly identified an incorrect state path access for the subtype property in a selector, which would cause styles to be incorrectly persisted for certain layer types.
dsuren1
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport includes following commits:
The commit 05874a3 has been included for the changes done geonode-mapstore-client side related to the improvement of the dataset data payload workflow.