This repository was archived by the owner on Jan 28, 2020. It is now read-only.
feat: Added getAssetStore for cross platform asset storage.#184
Open
M3TIOR wants to merge 3 commits intoGentenStudios:developfrom
Open
feat: Added getAssetStore for cross platform asset storage.#184M3TIOR wants to merge 3 commits intoGentenStudios:developfrom
M3TIOR wants to merge 3 commits intoGentenStudios:developfrom
Conversation
So, long story short I'm stupid. I spent a full week on this crap trying to make an asset manager class with loading features. It's a tiny push now, not what I was intending it to be... But I'm glad it's done. KISS: Keep It Simple Stupid 😑
vyomfadia
suggested changes
Dec 22, 2019
| using namespace qz::utils; | ||
|
|
||
| // Horizontal namespace shrinking to improve code readability. | ||
| #define FS std::filesystem |
Member
There was a problem hiding this comment.
Maybe use using fs = std::filesystem instead.
I actually didn't know about the `using` keywords declarative invocation. Thanks for pointing that out @beeperdeeper089 I'll keep a note of that for future occurrences.
Contributor
Author
|
Whelp... just realized that should have been a |
vyomfadia
approved these changes
Dec 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, long story short I'm stupid. I spent a full week on this crap
trying to make an asset manager class with loading features.
It's a tiny push now, not what I was intending it to be... But
I'm glad it's done. KISS: Keep It Simple Stupid 😑