This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Open
Conversation
…) ; updating code to use the C++ STL instead of C-style arrays/ptr to function
Commander.cpp line 38 and line 116
vyomfadia
suggested changes
Oct 27, 2019
Member
vyomfadia
left a comment
vyomfadia
left a comment
There was a problem hiding this comment.
Run a Clang format before the final merge, but the code seems good, just a few nitpicks I have. Get it compiling though! 😛
DontBelieveMe
suggested changes
Oct 27, 2019
Contributor
DontBelieveMe
left a comment
DontBelieveMe
left a comment
There was a problem hiding this comment.
In general, the code looks good :D but like beeper says if you could run clang-format on the changes, and address the few comments I've left - only little things so nothing major.
Overall though, good job 👍
Feat voxels static
Remove test code
…nto feat-commander
…nto feat-commander
…nto feat-commander
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a command registry and CLI interface.
The CommandBook is the registry that stores commands for use by a Commander. A Commander is constructed with a CommandBook and two streams (one in and one out) that can either be cin/cout for terminal use with the server or point to streams in the client (the chat terminal). The commander contains a loop that checks for input and executes commands.
The commanders have 3 built-in functions that don't exist in the CommandBook, these are hardcoded and can't be overwritten. A help function, a list function, and an exit function.