Conversation
remkos
reviewed
May 31, 2025
Contributor
remkos
left a comment
remkos
left a comment
There was a problem hiding this comment.
What is the point of removing the space after the function calls GMT_Read_Data, GMT_Report, sprintf, etc.?
I thought that the space was part of our coding style/
Member
Author
|
Must be the age but those spaces between function names and its arguments (that I never saw anywhere else) put a cognitive load on me when reading the code and trying to understand what it does that is highly annoying (to me). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was (and still is a bit) with header contents being fished from the text column. This PR fixes it but, for compat reasons, still fishes first text record and puts it in header too.
Fix #8736