FIX: grdinterpolate -E can't set correct unit#8734
Merged
joa-quim merged 1 commit intoGenericMappingTools:masterfrom May 18, 2025
Merged
FIX: grdinterpolate -E can't set correct unit#8734joa-quim merged 1 commit intoGenericMappingTools:masterfrom
grdinterpolate -E can't set correct unit#8734joa-quim merged 1 commit intoGenericMappingTools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug description
grdinterpolate -Ecan't set correct unit,(cube can be downloaded by
curl -s http://ds.iris.edu/spudservice/data/17996723 -o S362ANI_kmps.nc)Whats' changed
This part (
-E) should be similar to that ofgrdtrack. Ingrdtrack,E.unitand projection scale are determined after the grid data reading, but this is opposite ingrdinterpolate, see code below,gmt/src/grdinterpolate.c
Lines 464 to 479 in 5beb2bd
I use
printf()to check theGMT->current.map.dist[GMT_MAP_DIST].scalebefore and after theGMT_Read_Data(),scaleis redetermined.Gridhere is just used to determined the default interval. So I just change the position of the calling functionGMT_Read_Data()part, move upward a little bit.The new result seems fine,