Conversation
…trigger (closes #31) Agent-Logs-Url: https://github.com/Geek-MD/HA_Daily_Counter/sessions/5cad306e-c3e4-46e6-8c73-5042f6529cd5 Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Geek-MD
March 31, 2026 20:23
View session
Owner
|
Closes #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HA config flow forms are static: placing a
domain_filterdropdown and anEntitySelectoron the same step means the selector's domain is baked in at render time, so changing the dropdown never updates the entity list. This manifested as the entity picker always showingbinary_sensorentities regardless of which domain was selected.Config flow (FlowHandler)
async_step_userinto two steps:user— collects name + domain filter onlyfirst_trigger— rendersEntitySelector(domain=[chosen_domain])on a fresh step, guaranteeing the correct entity listasync_step_another_trigger— replaced the server-side entity list builder (SelectSelector+ text filter) with a nativeEntitySelector(EntitySelectorConfig()), enabling any entity domain for additional triggers with built-in searchOptions flow (OptionsFlowHandler)
async_step_trigger_domain(add path) andasync_step_edit_trigger_domain(edit path) before the entity selector steps; the edit path pre-selects the current entity's domain as defaultEntitySelectorSupporting changes
en.json,es.json,strings.json): addedfirst_trigger,trigger_domain,edit_trigger_domainsteps; removedtext_filterfield fromanother_triggermanifest.json: bumped to1.4.2CHANGELOG.md/README.mdupdated