Conversation
… in can_start and can_stop
… in can_start and can_stop
Was behind by 17 commits, merged at request of Daniel H.
dchansen06
added
Enhancement
(probably merge shenanagains) Co-authored-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com> Signed-off-by: Aagrim Hoysal <36976269+ahoysal@users.noreply.github.com>
Co-authored-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com> Signed-off-by: Aagrim Hoysal <36976269+ahoysal@users.noreply.github.com>
dchansen06
previously approved these changes
Mar 15, 2026
dchansen06
reviewed
Mar 15, 2026
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Lgtm, pending external test
dchansen06
reviewed
Mar 15, 2026
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Lgtm, pending external test
VihanJ
commented
Mar 15, 2026
Contributor
Author
VihanJ
left a comment
VihanJ
left a comment
There was a problem hiding this comment.
- Only supports STM32G474xx, no other families are supported.
dchansen06
approved these changes
Mar 15, 2026
Contributor
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Lgtm, pending external test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAN ISR
Problem and Scope
Description
Gotchas and Limitations
Testing
Testing Details
unit tests for can_init, can_release, and can_start are partially completed
need to write tests for can_stop, other tests may be needed as well.
Larger Impact
Additional Context and Ticket