Fixed multiple Tilemap issues#63
Open
AntonPetrov83 wants to merge 10 commits intoGamesRightMeow:mainfrom
Open
Conversation
added 9 commits
January 29, 2026 10:03
AntonPetrov83
changed the title
PD just skips invalid tiles.
SHiLLySiT
requested changes
Apr 7, 2026
Collaborator
SHiLLySiT
left a comment
SHiLLySiT
left a comment
There was a problem hiding this comment.
Looks good, thank you!
🛑 REQUEST: I added a testing framework. Can you merge in main (feel free to resolve tilemap conflicts with your changes) and add tests?
🛑 REQUEST: I added a changelog.md and notes in the contributing.md. Can you add a line or two summarizing your changes?
| @@ -85,11 +101,11 @@ function meta:drawIgnoringOffset(x, y, sourceRect) | |||
| end | |||
|
|
|||
| function meta:getSize() | |||
Collaborator
There was a problem hiding this comment.
🛑 REQUEST: can you add a test for this?
| return self._width, self._height | ||
| end | ||
|
|
||
| function meta:getPixelSize() |
Collaborator
There was a problem hiding this comment.
🛑 REQUEST: can you add a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62