Open
Conversation
… just rendering the lexica item rather than adding it as an itemstack, and show information when looking both for recipes and usages
…y just rendering the mana pool item rather than adding it as an itemstack
…the recipe ingredients and add seeds/livingrock.
combusterf
reviewed
Mar 28, 2026
|
|
||
| @Override | ||
| public void loadUsageRecipes(ItemStack ingredient) { | ||
| if(hasElvenKnowledge()) { |
Collaborator
There was a problem hiding this comment.
Existing features should not be removed.
Author
There was a problem hiding this comment.
hasElvenKnowledge's body has been commented for 11 years, presumably because iterating through the player's inventory every time uses/recipes are searched for (which happens on any item, not just ones relevant to this handler!) is laggy. Information like this shouldn't even be hidden in the first place and shouldn't require you to have the book in your inventory even if it should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit messages for all improvements.
Highlights:
Show lexicon entries when finding uses or recipes for items.
Let the Floating Flower handler use the overlay button to autocomplete recipes in the inventory/crafting table grid.
Fix transfer rects and prevent machines like the Mana Pool and Runic Altar from being added to bookmarked recipes for most handlers by rendering them in the background graphics step instead of adding them to the ingredients of the recipe.
Add seeds/livingrock to apothecary/runic handlers with a custom tooltip for seeds (can be changed with a lang key):
Most changes are fixing whitespace. Check this out to ignore the whitespace changes when reviewing. We really need to enable spotless because we will never actually sync with or contribute to upstream Botania from this fork due to the radical differences between them. New features already need to be backported manually (like the improvements to the Rosa Arcana) rather than being able to just cherrypick a commit or two.
GTNH's full pack works fine with these changes. I also already tested this with the Alfheim addon and needed to walk back some of my changes to make it work, since it extends the Petal Apothecary handler and what I can only assume is Kotlin nonsense didn't like my changes even though it should have been compatible. If somebody has a better solution that axes the stupid addCenterItem param for CachedPetalApothecaryRecipe and CachedRunicAltarRecipe, I'm all ears.