Do not add null byte for immutable strings#137
Merged
Flakebi merged 1 commit intoGPUOpen-Drivers:devfrom Mar 10, 2026
Merged
Conversation
`CreateGlobalString` will add a null byte to the end of string by default, which prevents us from getting the exact same string back as we set. This makes it hard to use for cases where we need exact string matching, such as function names lookup.
jundaliuAMD
force-pushed
the
string-null-byte
branch
from
6028aac to
373f608
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateGlobalStringwill add a null byte to the end of string by default, which prevents us from getting the exact same string back as we set.This makes it hard to use for cases where we need exact string matching, such as function names lookup.