Feature/1234 analysis view jetpack compose#1249
Closed
ThomasKiljanczykDev wants to merge 15 commits intoFutsch1:mainfrom
Closed
Feature/1234 analysis view jetpack compose#1249ThomasKiljanczykDev wants to merge 15 commits intoFutsch1:mainfrom
ThomasKiljanczykDev wants to merge 15 commits intoFutsch1:mainfrom
Conversation
…able to other modules
…tability issues
Owner
|
Phew, that's a big one. I will review it, but I would actually like to merge it. If we don't, I suppose all the work you put into it will be gone, and it will also be hard to keep it in sync with main if I continue implementing features. What we should have is working tests, and, as I said, I will review. Is there anything else I can do to help? Some refactoring on main? And if you like, we can discuss potential architectural changes together. I know that the architecture is not great, the app started as a pure Java app with my Android knowledge from ten years ago and has been growing a lot since... |
Contributor
Author
|
I'm closing this one for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.