[ENHANCEMENT] VRAM (GPU) Caching for Desktop targets

[PurSnake]

Linked Issues

#4030 and other, idunno

Description

Adds ability to load graphics into vram on desktop targets. (since web is funny and mobile works pretty good with compression)

Also requiers FunkinCrew/openfl#5 to be merged.

[EliteMasterEric]

• Code overall looks good.
• Good that you remembered to disable GPU caching on the bitmaps which are modified by the game (such as those altered by scalePartByWidth).
• One known bug, there is an issue with some of the shader code the mobile team put into the fork of Flixel which causes artifacts around the transparent edges of some sprites (most noticeable as a black outline around the main menu sprites, but many other sprites were affected too). Don't remember if the mobile team made the appropriate change to fix that issue.

Otherwise, this PR is great. My internal representation required replacing every instance of Assets.getBitmapData() with a Funkin' implementation, which required major refactors to sprites across the project, but by modifying Assets.getBitmapData() to upload by default you prevented this extra work entirely! Very clever.

As mentioned on the other PR, you should definitely try to contribute this to the mainstream OpenFL. Do note however that you should probably make allowGPU false by default unless you're fine with your PR being a breaking change, since anyone blindly updating their OpenFL without knowing about the new argument on getBitmapData would find any function that tries to edit a bitmap breaking!

[EliteMasterEric]

Code looks good but I do think that we should do extensive testing on this on all platforms. This will delay the feature to the Week 8 update.

[ender69flock]

You can add a description that says "Not recommended for low-end graphics cards."?

[PurSnake]

uhoh

[PurSnake]

Same with here I just lost changes

[PurSnake]

Or I'll restore it myself