[1.x] feat: store image dimensions to prevent layout shifts on lazy-loaded images#478
Open
huoxin233 wants to merge 2 commits intoFriendsOfFlarum:1.xfrom
Open
[1.x] feat: store image dimensions to prevent layout shifts on lazy-loaded images#478huoxin233 wants to merge 2 commits intoFriendsOfFlarum:1.xfrom
huoxin233 wants to merge 2 commits intoFriendsOfFlarum:1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Supersedes #441
Changes proposed in this pull request:
Backport fix #464 to 1.x
Reviewers should focus on:
Screenshot
Confirmed
composer test).Required changes: