Bugfix for Subs page#9194
Open
caffeineaddiction wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
YouTube changed channel video/live stream tabs to return
lockupViewModelnodes instead ofvideoRenderernodes. The youtubei.js library parses these asLockupViewobjects, but its.videosgetter doesn't include them, causinggetLocalChannelVideos()andgetLocalChannelLiveStreams()to return empty arrays. This fix adds a fallback in both functions to extractLockupViewnodes (withcontent_type === 'VIDEO') from the channel tab's memo when.videosreturns empty. The existingparseLockupView()function already handles full VIDEOparsing, so
parseLocalChannelVideos()was updated to routeLockupViewitems through it alongside traditionalVideonodes.Also adds
channelName/channelIdfallbacks inparseLockupView()'s VIDEO case, since metadata rows on a channel's own page contain views/time rather than channel info.Screenshots
Testing
Currently Release says: "Your subscribed channels currently does not have any videos"
This version fixes this
Desktop
Additional context