Feature: Add fallback behavior for RSS ratelimiting "Closes #8653"#9157
Open
laclcia wants to merge 1 commit into
Open
Feature: Add fallback behavior for RSS ratelimiting "Closes #8653"#9157laclcia wants to merge 1 commit into
laclcia wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
PR: waiting for review
Member
|
YT/FT broken on getting videos on sub just this hour (no issue a few hours ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
8653
Description
this add's a toggle in the subscription section of the settings page (default off) witch when enabled will change the behavior when fetching subscriptions for large (above 125) lists. instead of falling back to RSS witch often has problems as YT's rss goes down often it will instead chunk fetch requests in chunk's of 80 separated by 2 seconds (2000 ms) to avoid rate limiting without relying on rss.
Screenshots
Testing
1 launch app and refresh a large subscription list. the RSS fetch should still work.
2 go to settings tab and the subscription subsection and check "limit request fallback without RSS"
3 go back to subscriptions and refresh. you should notice the bottom loading bar stopping for 2 sec then resuming (and stopping again since it fetches in chunk's of 80) a few times.
4 once all subscriptions are fetched they should all have timestamps confirming it worked without rss.
Desktop
Additional context
i originally created a proof of concept for this about a month ago and posted the diff in the original feature request thread here #8653 (comment) . i have been running that fix daily on my computers (and some friends) since then and it work's without problem.
English is a second language for me and i am not a developer by trade. this is the second pull request i have made (the first was for a one line fix for another most likely abandoned project). i have tried to the best of my ability to follow the guidelines in the "Code Contributions" file.