ct_cursor: Predict cursor type for CS_CURSOR_DECLARE.#584
Closed
ucko wants to merge 1 commit into
Closed
Conversation
Request forward-only cursors for updates, keyset-driven cursors otherwise. Regardless, specify optimistic cursors, which check timestamps and, when they're not available, values. Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
freddy77
reviewed
Apr 18, 2025
| while (tok != NULL) { | ||
| s = savept; | ||
|
|
||
| if (strcasecmp(tok, "FOR") == 0) { |
Contributor
There was a problem hiding this comment.
get_next_tok is not terminating the tokens so if you have a query like select * from table for update get_next_token will return for update, not for.
freddy77
reviewed
Apr 18, 2025
Comment on lines
+3972
to
+3974
| eBaseline, | ||
| eFor, | ||
| eForUpdate |
Contributor
There was a problem hiding this comment.
camel case is a bit out of style in FreeTDS. What e stands for? What about tok_baseline, tok_for, tok_for_update ?
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request forward-only cursors for updates, keyset-driven cursors otherwise. Regardless, specify optimistic cursors, which check timestamps and, when they're not available, values.
Split from #555.