dbwritetext: Fail if dbconvert does.#577
Closed
ucko wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
freddy77
reviewed
May 30, 2024
Comment on lines
+6656
to
+6663
| len = dbconvert(dbproc, SYBBINARY, (BYTE *) textptr, textptrlen, | ||
| SYBCHAR, (BYTE *) textptr_string, -1); | ||
| if (len < 0) | ||
| return FAIL; | ||
| len = dbconvert(dbproc, SYBBINARY, (BYTE *) timestamp, 8, SYBCHAR, | ||
| (BYTE *) timestamp_string, -1); | ||
| if (len < 0) | ||
| return FAIL; |
Contributor
There was a problem hiding this comment.
But this function cannot fail with these arguments!
Contributor
Author
|
Good point. These checks come from a former colleague who left years ago; I'm unclear on why he added them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #555.