Skip to content

ct_connect: Set client_charset in addition to server_charset.#574

Closed
ucko wants to merge 1 commit into
FreeTDS:masterfrom
ucko:ncbi-2024-05-ct_connect-client_charset
Closed

ct_connect: Set client_charset in addition to server_charset.#574
ucko wants to merge 1 commit into
FreeTDS:masterfrom
ucko:ncbi-2024-05-ct_connect-client_charset

Conversation

@ucko
Copy link
Copy Markdown
Contributor

@ucko ucko commented May 30, 2024

Split from #555.

Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
@freddy77
Copy link
Copy Markdown
Contributor

Not setting client_charset is done on purpose. This allows to pick up the server charset and convert properly on the client side.

@ucko
Copy link
Copy Markdown
Contributor Author

ucko commented Jul 18, 2024

Good point. FWIW, the original patch predated CS_CLIENTCHARSET support, and I hadn't registered the latter's availability.

@ucko ucko closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants