Address "declared with greater visibility" warnings.#563
Closed
ucko wants to merge 1 commit into
Closed
Conversation
Ensure that members of types that should be unhidden have unhidden forward declarations; likewise for their members, recursively. To that end, give CS_SERVERMSG_*'s underlying struct/union types explicit names (cs_servermsg_*). Signed-off-by: Aaron M. Ucko <ucko@ncbi.nlm.nih.gov>
Contributor
|
I would say this patch is doing exactly the opposite of what is expected, these structures are meant to not be visible externally. |
Contributor
Author
|
Good point, a closer look revealed that I encountered such warnings only from outside projects that were using private FreeTDS headers. I'll withdraw this PR accordingly and instead work on proposing public APIs for any needed functionality the CTLIB front-end doesn't already expose. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that members of types that should be unhidden have unhidden forward declarations; likewise for their members, recursively. To that end, give CS_SERVERMSG_'s underlying struct/union types explicit names (cs_servermsg_).
Split from #555.