Skip to content

Use text input instead of button so autocomplete works on Firefox#151

Merged
sjcallender merged 18 commits intomainfrom
feature/firefox-autocomplete
Mar 3, 2026
Merged

Use text input instead of button so autocomplete works on Firefox#151
sjcallender merged 18 commits intomainfrom
feature/firefox-autocomplete

Conversation

@sjcallender
Copy link
Copy Markdown
Contributor

@sjcallender sjcallender commented Mar 2, 2026

  • https://3.basecamp.com/3091851/buckets/26456130/todos/9588904795#__recording_9633716521
    • Switches to use <input type="text"> instead of <button> because Firefox is strict about not auto-filling invisible form fields. This allows us to set autocomplete values.
    • Merge matchAutofillValue, selectByValue, and matchOptionByValue into selectByValue
    • prevents the State field from being focused after autofill is performed. keeps the focus on the original field.
    • prevents the first letter from being ignored in the text input field if that letter keydown was what triggered the dropdown to open.
    • Fix front-end validation
    • Remove state/region field for countries with no state/region options

@sjcallender sjcallender merged commit d4b66e5 into main Mar 3, 2026
3 checks passed
@sjcallender sjcallender deleted the feature/firefox-autocomplete branch March 3, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant