Add an example app with paths extraction#49
Open
vkutuev wants to merge 24 commits intoFormalLanguageConstrainedPathQuerying:mainfrom
Open
Add an example app with paths extraction#49vkutuev wants to merge 24 commits intoFormalLanguageConstrainedPathQuerying:mainfrom
vkutuev wants to merge 24 commits intoFormalLanguageConstrainedPathQuerying:mainfrom
Conversation
Better examples for path extraction
bachish
approved these changes
Mar 8, 2026
Collaborator
bachish
left a comment
bachish
left a comment
There was a problem hiding this comment.
Great that you add human-readable examples. I left some issues, but they are not critical can be fixed in next MR's.
Collaborator
There was a problem hiding this comment.
Why "me" and "vkutuev" in path? It would be better to name with corresponds to project/task semantic, not author (you can set author in file jacadoc if needed)
| class PointsToGrammar : Grammar() { | ||
| val S by Nt().asStart() | ||
| val Alias by Nt() | ||
| val PointsTo by Nt(many("assign" or ("load_0" * Alias * "store_0") |
Collaborator
There was a problem hiding this comment.
Are any paper/online page with more detailed description of this task and grammar? A link would be great.
Comment on lines
+50
to
+53
| fun getPathFromSppf(node: RangeSppfNode<Int>, maxDepth: Int): List<List<OutEdge>>? { | ||
| if (maxDepth == 0) { | ||
| return null | ||
| } |
Collaborator
There was a problem hiding this comment.
Would be grear unit tests for this speccific part and pointsTo task in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a demo application for extracting paths