SDKS-4549: Update Protect Callback With New Signals SDK Config#581
SDKS-4549: Update Protect Callback With New Signals SDK Config#581SteinGabriel merged 5 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 9bec7f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 9bec7f2
☁️ Nx Cloud last updated this comment at |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #581 +/- ##
===========================================
- Coverage 57.14% 56.50% -0.64%
===========================================
Files 105 105
Lines 31752 28400 -3352
Branches 1800 1620 -180
===========================================
- Hits 18145 16048 -2097
+ Misses 13607 12352 -1255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Just want to confirm that this is the latest and correct Signals version from the Protect team. If we've confirmed this version with them, then I'm good.
There was a problem hiding this comment.
Yeah, I grabbed this code from this link: https://apps.pingone.com/signals/web-sdk/latest/signals-sdk.js, which was provided by Itai this past Monday on Slack.
JIRA Ticket
Description
This PR updates Ping Protect initialization to support the new
signalsInitializationOptionscallback property from AM.What Changed
PingOneProtectInitializeCallback#getConfig()now:signalsInitializationOptionsdirectly when present as an objectping-protecttypes widened to support pass-through init option shapes(
SignalsInitializationOptions,ProtectNodeInitializeConfig)PIProtect.start()now resumes behavioral collection whenbehavioralDataCollectionistrueor'true'signalsInitializationOptionspass-through'true'/'false'behavioral collection handling inping-protectHow Has This Been Tested?
Tested with the e2e autoscript apps as well as added a test assertion for our automated e2e test suite.