Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ struct AppState
std::deque<std::wstring> recentFiles;
BackgroundSettings background;
std::wstring customIconPath;
int windowX = CW_USEDEFAULT;
int windowY = CW_USEDEFAULT;
int windowWidth = 640;
int windowHeight = 480;
};

typedef BOOL(WINAPI *fnAllowDarkModeForWindow)(HWND hWnd, BOOL allow);
Expand Down
18 changes: 17 additions & 1 deletion src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,21 @@ LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
g_state.closing = false;
return 0;
case WM_DESTROY:
// Save window position and size before destroying
{
WINDOWPLACEMENT wp = {};
wp.length = sizeof(WINDOWPLACEMENT);
if (GetWindowPlacement(hwnd, &wp))
{
// Always save the normal position, even if maximized or minimized
RECT rect = wp.rcNormalPosition;
g_state.windowX = rect.left;
g_state.windowY = rect.top;
g_state.windowWidth = rect.right - rect.left;
g_state.windowHeight = rect.bottom - rect.top;
}
SaveWindowSettings();
}
if (g_state.hFont)
{
DeleteObject(g_state.hFont);
Expand Down Expand Up @@ -556,6 +571,7 @@ int WINAPI wWinMain(HINSTANCE hInstance, HINSTANCE, LPWSTR lpCmdLine, int nCmdSh
}

LoadFontSettings();
LoadWindowSettings();

WNDCLASSEXW wc = {};
wc.cbSize = sizeof(wc);
Expand All @@ -578,7 +594,7 @@ int WINAPI wWinMain(HINSTANCE hInstance, HINSTANCE, LPWSTR lpCmdLine, int nCmdSh
const auto &lang = GetLangStrings();
std::wstring initialTitle = lang.untitled + L" - " + lang.appName;
g_hwndMain = CreateWindowExW(0, L"NotepadClass", initialTitle.c_str(),
WS_OVERLAPPEDWINDOW | WS_MAXIMIZEBOX, CW_USEDEFAULT, CW_USEDEFAULT, 640, 480,
WS_OVERLAPPEDWINDOW | WS_MAXIMIZEBOX, g_state.windowX, g_state.windowY, g_state.windowWidth, g_state.windowHeight,
nullptr, nullptr, hInstance, nullptr);
g_hAccel = LoadAcceleratorsW(hInstance, MAKEINTRESOURCEW(IDR_ACCEL));
ShowWindow(g_hwndMain, nCmdShow);
Expand Down
91 changes: 90 additions & 1 deletion src/modules/settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
███ ███ ▀

Settings management for persisting user preferences via Windows Registry.
Handles font name and font size storage and retrieval.
Handles font settings, always on top, window size and position storage and retrieval.
*/

#include "settings.h"
Expand All @@ -25,6 +25,10 @@
#define FONT_ITALIC_VALUE L"FontItalic"
#define FONT_UNDERLINE_VALUE L"FontUnderline"
#define ALWAYS_ON_TOP_VALUE L"AlwaysOnTop"
#define WINDOW_X_VALUE L"WindowX"
#define WINDOW_Y_VALUE L"WindowY"
#define WINDOW_WIDTH_VALUE L"WindowWidth"
#define WINDOW_HEIGHT_VALUE L"WindowHeight"
#define MIN_FONT_SIZE 8
#define MAX_FONT_SIZE 72

Expand Down Expand Up @@ -119,3 +123,88 @@ void SaveFontSettings()
RegCloseKey(hKey);
}
}

void LoadWindowSettings()
{
HKEY hKey;
if (RegOpenKeyExW(HKEY_CURRENT_USER, SETTINGS_KEY, 0, KEY_READ, &hKey) == ERROR_SUCCESS)
{
DWORD x = 0;
DWORD size = sizeof(x);
if (RegQueryValueExW(hKey, WINDOW_X_VALUE, nullptr, nullptr, reinterpret_cast<LPBYTE>(&x), &size) == ERROR_SUCCESS)
{
// Cast DWORD to int - on Windows, this preserves negative coordinates correctly
g_state.windowX = static_cast<int>(x);
}

DWORD y = 0;
size = sizeof(y);
if (RegQueryValueExW(hKey, WINDOW_Y_VALUE, nullptr, nullptr, reinterpret_cast<LPBYTE>(&y), &size) == ERROR_SUCCESS)
{
// Cast DWORD to int - on Windows, this preserves negative coordinates correctly
g_state.windowY = static_cast<int>(y);
}

DWORD width = 0;
size = sizeof(width);
if (RegQueryValueExW(hKey, WINDOW_WIDTH_VALUE, nullptr, nullptr, reinterpret_cast<LPBYTE>(&width), &size) == ERROR_SUCCESS)
{
if (width > 0)
{
g_state.windowWidth = static_cast<int>(width);
}
}

DWORD height = 0;
size = sizeof(height);
if (RegQueryValueExW(hKey, WINDOW_HEIGHT_VALUE, nullptr, nullptr, reinterpret_cast<LPBYTE>(&height), &size) == ERROR_SUCCESS)
{
if (height > 0)
{
g_state.windowHeight = static_cast<int>(height);
}
}
Comment on lines +148 to +166
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoadWindowSettings() assigns registry REG_DWORD width/height directly to int after only checking > 0. If the stored DWORD exceeds INT_MAX, the cast can wrap to a negative int, which can make CreateWindowExW fail or create invalid geometry. Please bound-check the DWORDs (e.g., <= INT_MAX and within a reasonable min/max) before casting/assigning, and consider resetting to defaults when out of range.

Copilot uses AI. Check for mistakes.

RegCloseKey(hKey);
}

// Validate that the window position is visible on at least one monitor
RECT rc = {g_state.windowX, g_state.windowY, g_state.windowX + g_state.windowWidth, g_state.windowY + g_state.windowHeight};
HMONITOR hMonitor = MonitorFromRect(&rc, MONITOR_DEFAULTTONULL);
Comment on lines +171 to +173
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RECT construction uses g_state.windowX + g_state.windowWidth and g_state.windowY + g_state.windowHeight in signed arithmetic. If registry values are large/corrupted, these additions can overflow int, which is undefined behavior in C++. Consider using a wider intermediate type and clamping to LONG range (or validating inputs) before building the RECT for MonitorFromRect().

Copilot uses AI. Check for mistakes.
if (!hMonitor)
{
// Window would be off-screen, reset to default
g_state.windowX = CW_USEDEFAULT;
g_state.windowY = CW_USEDEFAULT;
}
}

void SaveWindowSettings()
{
HKEY hKey;
if (RegCreateKeyExW(HKEY_CURRENT_USER, SETTINGS_KEY, 0, nullptr, 0, KEY_WRITE, nullptr, &hKey, nullptr) == ERROR_SUCCESS)
{
// Store coordinates as REG_DWORD - static_cast preserves bit pattern for negative values
DWORD x = static_cast<DWORD>(g_state.windowX);
RegSetValueExW(hKey, WINDOW_X_VALUE, 0, REG_DWORD,
reinterpret_cast<const BYTE *>(&x),
sizeof(x));

DWORD y = static_cast<DWORD>(g_state.windowY);
RegSetValueExW(hKey, WINDOW_Y_VALUE, 0, REG_DWORD,
reinterpret_cast<const BYTE *>(&y),
sizeof(y));

DWORD width = static_cast<DWORD>(g_state.windowWidth);
RegSetValueExW(hKey, WINDOW_WIDTH_VALUE, 0, REG_DWORD,
reinterpret_cast<const BYTE *>(&width),
sizeof(width));

DWORD height = static_cast<DWORD>(g_state.windowHeight);
RegSetValueExW(hKey, WINDOW_HEIGHT_VALUE, 0, REG_DWORD,
reinterpret_cast<const BYTE *>(&height),
sizeof(height));

RegCloseKey(hKey);
}
}
2 changes: 2 additions & 0 deletions src/modules/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@

void LoadFontSettings();
void SaveFontSettings();
void LoadWindowSettings();
void SaveWindowSettings();