Conversation
…rectly with non-default SCALETUNE Agent-Logs-Url: https://github.com/derselbst/fluidsynth/sessions/e930e1d1-66e9-487f-82ff-731ec5c76abb Co-authored-by: derselbst <8152480+derselbst@users.noreply.github.com>
Member
Author
|
Retested my modified version of Chris' test SF2 and confirmed that the issue is gone. Some regression tests fail, because individual instruments are now being played back at a slightly different peak, which is expected. |
|
zefie
pushed a commit
to zefie/fluidsynth
that referenced
this pull request
Apr 9, 2026
* Add failing unit test for issue FluidSynth#1773: sample fine-tune applied incorrectly with non-default SCALETUNE (copilot) * Fix the bug (derselbst) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: derselbst <8152480+derselbst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1773
TODO: