Skip to content

fix: left align overflow items in Vaadin 25#30

Merged
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1
Mar 5, 2026
Merged

fix: left align overflow items in Vaadin 25#30
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 5, 2026

Summary by CodeRabbit

  • Style
    • Tab link styling has been updated to utilize full available width, improving usability and visual presentation of tab navigation.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0877674e-6003-4687-aff1-3254ad6aad87

📥 Commits

Reviewing files that changed from the base of the PR and between c234781 and 48dd037.

📒 Files selected for processing (1)
  • src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css

Walkthrough

This pull request adds a width: 100% CSS property to the tab link selector in the enhanced tabs component stylesheet, allowing tab links to occupy the full width of their container within the menu bar list box.

Changes

Cohort / File(s) Summary
Enhanced Tabs Stylesheet
src/main/resources/META-INF/frontend/fcEnhancedTabs/fc-enhanced-tabs.css
Added width: 100% property to vaadin-menu-bar-list-box[theme="fc-enhanced-tabs"] vaadin-tab a[href] selector to expand tab link width.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding CSS width property to fix left alignment of overflow items in Vaadin 25, which directly corresponds to the single-line CSS modification shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch javier-godoy-patch-1

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 5, 2026 15:07
@javier-godoy javier-godoy marked this pull request as ready for review March 5, 2026 15:08
@paodb paodb merged commit 6f930a8 into master Mar 5, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Mar 5, 2026
@paodb paodb deleted the javier-godoy-patch-1 branch March 5, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants