Open
Conversation
…tification_shown - Increase stdin read timeout from 0.1s to 0.5s to avoid missing payloads - Add fallback session ID lookup by PPID when cwd differs between hooks - Return notification_shown from Electron /api/notify and /notify endpoints - Fall back to browser tracker when Electron notification unsupported Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change PPID glob from {ppid}* to {ppid}-* to prevent prefix collisions
- Wrap stat() in sort key with try/except for race-deletion safety
- Legacy /notify endpoint returns notification_shown: false (no .show() call)
- Skip 0.5s stdin timeout when running interactively (isatty check)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification_shownboolean from Electron/api/notifyand/notifyendpointsBased on ideas from #16 (now closed), reimplemented against current main.
Test plan
notification_shownin/api/notifyresponseCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com