Skip to content

chore(auth): remove custom header handling code #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordanbrauer merged 2 commits into from
May 12, 2026
+10 −12
Merged

chore(auth): remove custom header handling code #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeafc26
remove custom auth header code
jordanbrauer May 11, 2026
f3aabef
Merge branch 'next' into jordan/remove-custom-auth-headers
jordanbrauer May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/finch/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,11 @@ def qs(self) -> Querystring:
return Querystring(array_format="brackets")

@override
def auth_headers(self) -> dict[str, str]:
if self._bearer_auth:
return self._bearer_auth
if self._basic_auth:
return self._basic_auth
return {}
def _auth_headers(self, security: SecurityOptions) -> dict[str, str]:
return {
**(self._bearer_auth if security.get("bearer_auth", False) else {}),
**(self._basic_auth if security.get("basic_auth", False) else {}),
}

@property
def _bearer_auth(self) -> dict[str, str]:
Expand Down Expand Up @@ -567,12 +566,11 @@ def qs(self) -> Querystring:
return Querystring(array_format="brackets")

@override
def auth_headers(self) -> dict[str, str]:
if self._bearer_auth:
return self._bearer_auth
if self._basic_auth:
return self._basic_auth
return {}
def _auth_headers(self, security: SecurityOptions) -> dict[str, str]:
return {
**(self._bearer_auth if security.get("bearer_auth", False) else {}),
**(self._basic_auth if security.get("basic_auth", False) else {}),
}

@property
def _bearer_auth(self) -> dict[str, str]:
Expand Down
Loading