Add Goal option + skip locations instead of exclude#139
Open
Rurusachi wants to merge 10 commits into
Open
Conversation
Andrewki44
requested changes
May 9, 2026
Member
Andrewki44
left a comment
Andrewki44
left a comment
There was a problem hiding this comment.
General review looks very good, just one very minor naming change in options.py
Otherwise, approved pending results of pre-release testing this evening
Member
|
Note: |
Andrewki44
requested changes
May 9, 2026
Member
Andrewki44
left a comment
Andrewki44
left a comment
There was a problem hiding this comment.
Mars Sigil Generation Errors.
There are still generation issues being presented by the fuzzer, but I have run out of time to troubleshoot for now
Andrewki44
requested changes
May 9, 2026
| dark_valefor = world.get_location(world.location_id_to_name[2 | BossOffset]) | ||
| world.set_rule(besaid_jecht_sphere, CanReachLocation(dark_valefor.name)) | ||
| if world.options.jecht_spheres.value: | ||
| if world.location_id_to_name[2 | BossOffset] not in world.skip_locations: |
Member
There was a problem hiding this comment.
Suggested change
| if world.location_id_to_name[2 | BossOffset] not in world.skip_locations: | |
| if world.location_id_to_name[2 | BossOffset] not in world.skip_locations and world.location_id_to_name[27 | OtherOffset] not in world.skip_locations: |
Co-authored-by: Andrew K <53620706+Andrewki44@users.noreply.github.com>
Co-authored-by: Andrew K <53620706+Andrewki44@users.noreply.github.com>
Co-authored-by: Andrew K <53620706+Andrewki44@users.noreply.github.com>
Co-authored-by: Andrew K <53620706+Andrewki44@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #26 and #116. Needs testing to make sure removing locations instead of excluding them didn't break the logic somehow. For now removed locations just have "Potion x 10" placed on them and are treated as any other location by the client