Skip to content

Add Deathlink#207

Open
EvelynTSMG wants to merge 28 commits into
mainfrom
deathlink
Open

Add Deathlink#207
EvelynTSMG wants to merge 28 commits into
mainfrom
deathlink

Conversation

@EvelynTSMG
Copy link
Copy Markdown
Member

Would resolve #48.

@EvelynTSMG
Copy link
Copy Markdown
Member Author

At the moment, completely and utterly untested. I ran out of time for today!

@EvelynTSMG EvelynTSMG marked this pull request as ready for review May 6, 2026 02:32
@EvelynTSMG EvelynTSMG requested a review from a team May 6, 2026 02:32
@EvelynTSMG
Copy link
Copy Markdown
Member Author

After a bit testing in a limited environment, this is ready for review.
The code isn't the cleanest, but so long as it works it can be like this for now.
We can improve it after a refactor targeting hooks.cs and archipelago.cs.

Known issues:

  • Dying to Doom does not trigger the Post-KO code, hence avoiding sending a deathlink.

@EvelynTSMG EvelynTSMG requested review from Andrewki44 and Rurusachi May 6, 2026 02:39
Copy link
Copy Markdown
Member

@Andrewki44 Andrewki44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some iterative testing last week this seemed pretty successful.

Cannot be merged until fahrenheit-crew/fahrenheit#138 is complete.

Would also like to see an associated Apworld PR for this, but not necessary for it to be merged. The option works independently on client side as-is.

@EvelynTSMG
Copy link
Copy Markdown
Member Author

A successful merge would increase the urgency of #206, as it would cause queue doubled deathlinks when one is received.

@Andrewki44
Copy link
Copy Markdown
Member

Should we consider that blocking in that case?

@EvelynTSMG
Copy link
Copy Markdown
Member Author

I believe the issue is rare enough to not need to be considered blocking, but do as you will.

Copy link
Copy Markdown
Member Author

@EvelynTSMG EvelynTSMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary changes

Comment thread src/modules/deathlink.cs
Comment thread src/modules/deathlink.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deathlink

2 participants