bump cmake min required version#386
Merged
stevengj merged 1 commit intoFFTW:masterfrom Apr 22, 2026
Merged
Conversation
Contributor
|
It's annoying that merely being compatible with old versions (not requiring them) leads to warnings. 3.10 is only 7 years old. |
|
Alternative would be to change to a more explicit range of compatible versions: |
|
+1 |
Contributor
|
Seems like we might as well merge this since it is causing problems, and we don't care that much about supporting old |
Contributor
|
(The primary build system for FFTW continues to be autoconf/configure … |
|
This fixes #381. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake support for versions <3.10 is deprecated and to be removed soon. Configuring fftw3 with the current min version leads to lengthy CMake warnings which clog the configure log.