Fix: Log level filter not applying in logs page#781
Merged
chubes4 merged 2 commits intoExtra-Chill:mainfrom Mar 10, 2026
Merged
Fix: Log level filter not applying in logs page#781chubes4 merged 2 commits intoExtra-Chill:mainfrom
chubes4 merged 2 commits intoExtra-Chill:mainfrom
Conversation
Tools now respect their declared contexts ('pipeline', 'chat', etc.) in the admin UI.
Previously, all tools were shown regardless of context, causing confusion.
Changes:
- ToolManager::get_tools_for_api() now accepts optional context parameter
- /tools REST endpoint supports context query parameter
- React useTools() hook defaults to 'pipeline' context
- Added contexts field to API response for transparency
Fixes inconsistency where chat-only tools appeared in pipeline step config.
The log level dropdown and search weren't triggering table refreshes. State was stored on window object without any reactive connection. Changes: - Lifted filter state to LogsApp component - Pass filters as props to LogsFilters and LogsTable - Removed window.__dmLogsFilters hack - Filters now properly trigger query refetch via TanStack Query Fixes filter UI not affecting log results.
chubes4
approved these changes
Mar 10, 2026
Member
chubes4
left a comment
chubes4
left a comment
There was a problem hiding this comment.
Looks good to me. Lifting the logs filter state into React state is the right fix and removes the non-reactive window hack. The failing lint check appears to be unrelated to this PR and instead caused by homeboy-action being ahead of the released Homeboy CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The log level dropdown and search field appeared to work but didn't actually filter the logs. Selecting a different level or typing in the search box didn't trigger any data refresh.
Root Cause
Filter state was stored on
window.__dmLogsFiltersas a hack to avoid prop drilling.LogsTableonly read it once during initial render. When filters changed, there was no mechanism to trigger a re-render or refetch the data.Solution
LogsAppcomponent with proper ReactuseStatefiltersandonFiltersChangeas props toLogsFiltersfiltersas prop toLogsTablewindow.__dmLogsFiltershackChanges
LogsApp.jsx: Added state management for filtersLogsFilters.jsx: Accept filters via props instead of local stateLogsTable.jsx: Accept filters via props instead of reading from windowTesting