Skip to content

[Snyk] Fix for 1 vulnerabilities#903

Open
MelvinBot wants to merge 12 commits intomainfrom
snyk-fix-61dcdb651e9965a37f389a35167f85bb
Open

[Snyk] Fix for 1 vulnerabilities#903
MelvinBot wants to merge 12 commits intomainfrom
snyk-fix-61dcdb651e9965a37f389a35167f85bb

Conversation

@MelvinBot
Copy link

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
⚠️ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue
high severity Uncontrolled Recursion
SNYK-JS-FLATTED-15518041

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-FLATTED-15518041
@MelvinBot MelvinBot requested a review from a team as a code owner March 17, 2026 15:20
@melvin-bot melvin-bot bot requested review from Valforte and removed request for a team March 17, 2026 15:21
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Valforte
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@Valforte
Copy link
Contributor

recheck

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 18, 2026
@Valforte
Copy link
Contributor

flatted is a deep dependency of eslint, so it had to be upgraded. As it needed a major version some more changes were required, including the conversion of .eslintrc.js and .eslintignore to eslint.config.mjs. This change also prompted me to fix a few lint errors that poped up.

@Valforte Valforte self-assigned this Mar 18, 2026
@Valforte Valforte requested review from a team and removed request for Valforte March 18, 2026 15:17
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team March 18, 2026 15:18
Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is a lot of changes for a version bump. Looking at the vulnerability, it looks like it only affects eslint which isn't a real attack vector. Is this really a change that we need to make? To me it feels like something we could ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants