Skip to content

feat: integrate eppo module with android-sdk-framework (v3 → v4 migration) #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
typotter wants to merge 13 commits into
base: typo/v4/add-framework-module
Choose a base branch
from
Open

feat: integrate eppo module with android-sdk-framework (v3 → v4 migration) #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4cf97c0
feat: integrate eppo module with android-sdk-framework (v3 to v4 migr…
typotter Mar 12, 2026
cc367f5
fix: apply critical test infrastructure fixes
typotter Mar 12, 2026
57db659
fix: remove unused Configuration import
typotter Mar 12, 2026
5577464
fix: add missing OutputStream import for Android API 26 compatibility
typotter Mar 12, 2026
de77789
fix: replace readAllBytes() with IOUtils.toByteArray() for Android AP…
typotter Mar 12, 2026
8cda238
refactor: move GsonConfigurationCodec to example module, fix init err…
typotter Mar 20, 2026
311f38f
chore: bump to SNAPSHOT versions and publish both modules in workflow
typotter Mar 20, 2026
ce6bfcf
chore: bump eppo to 5.0.0-SNAPSHOT (major version bump for v4 framewo…
typotter Mar 20, 2026
a346524
feat: publish snapshots on snapshot/* branches
typotter Mar 20, 2026
6f39fba
fix: address code review issues in eppo module and example app
typotter Mar 23, 2026
2c10c3c
fix: use snapshot/** pattern to match nested snapshot branch names
typotter Mar 20, 2026
474cc6c
chore: switch example app to consume published SNAPSHOT artifacts
typotter Mar 23, 2026
0cc4d2a
style: fix spotless formatting in CustomClientActivity
typotter Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/publish-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Publish SDK Snapshot artifact

on:
push:
branches: [main]
branches: [main, 'snapshot/**']

env:
CI: true
Expand All @@ -28,10 +28,14 @@ jobs:
java-version: 17
distribution: 'adopt'

- name: Stage snapshot artifact
run: ./gradlew eppo:assemble eppo:publish -Psnapshot
- name: Stage snapshot artifacts
run: ./gradlew android-sdk-framework:assemble android-sdk-framework:publish eppo:assemble eppo:publish -Psnapshot
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow runs android-sdk-framework:publish / eppo:publish in the "Stage snapshot artifacts" step and then runs publishAllPublicationsToMavenCentralRepository for each module afterwards. Since publish already triggers PublishToMavenRepository tasks, this is likely redundant and can double-publish (or fail with "already published"). Consider making the staging step assemble-only (or publish to MavenLocal) and keep the actual Maven Central publishing in the dedicated steps.

Suggested change
run: ./gradlew android-sdk-framework:assemble android-sdk-framework:publish eppo:assemble eppo:publish -Psnapshot
run: ./gradlew android-sdk-framework:assemble eppo:assemble -Psnapshot

Copilot uses AI. Check for mistakes.

- name: Publish Snapshot to Maven Central Portal
- name: Publish framework snapshot to Maven Central Portal
working-directory: android-sdk-framework
run: ../gradlew publishAllPublicationsToMavenCentralRepository -Psnapshot --no-daemon --stacktrace

- name: Publish SDK snapshot to Maven Central Portal
working-directory: eppo
run: ../gradlew publishAllPublicationsToMavenCentralRepository -Psnapshot --no-daemon --stacktrace

Expand Down
2 changes: 1 addition & 1 deletion android-sdk-framework/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

group = "cloud.eppo"
version = "0.1.0"
version = "0.1.0-SNAPSHOT"

android {
namespace "cloud.eppo.android.framework"
Expand Down
5 changes: 2 additions & 3 deletions android-sdk-framework/src/main/java/cloud/eppo/android/framework/AndroidBaseClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,12 @@ public CompletableFuture<AndroidBaseClient<JsonFlagType>> buildAndInitAsync() {
(success, ex) -> {
if (ex == null && Boolean.TRUE.equals(success)) {
ret.complete(newInstance);
} else if (offlineMode || failCount.incrementAndGet() == 2) {
} else if (offlineMode || ex != null || failCount.incrementAndGet() == 2) {
ret.completeExceptionally(
new EppoInitializationException(
"Unable to initialize client; Configuration could not be loaded", ex));
} else {
Log.i(TAG, "Initial config was not used.");
failCount.incrementAndGet();
Log.i(TAG, "Initial config was not used; waiting for fetch.");
}
return null;
});
Expand Down
6 changes: 4 additions & 2 deletions eppo/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

group = "cloud.eppo"
version = "4.12.1"
version = "5.0.0-SNAPSHOT"

android {
buildFeatures.buildConfig true
Expand Down Expand Up @@ -68,14 +68,16 @@ ext.versions = [
]

dependencies {
api 'cloud.eppo:sdk-common-jvm:3.13.1'
api project(':android-sdk-framework')
api 'cloud.eppo:sdk-common-jvm:4.0.0-SNAPSHOT'

implementation 'org.slf4j:slf4j-api:2.0.17'

implementation "androidx.core:core:${versions.androidx_core}"
implementation "com.squareup.okhttp3:okhttp:${versions.okhttp}"
implementation "com.github.zafarkhaja:java-semver:${versions.semver}"
implementation "com.fasterxml.jackson.core:jackson-databind:2.19.1"
implementation "com.fasterxml.jackson.module:jackson-module-parameter-names:2.19.1"

testImplementation "junit:junit:${versions.junit}"
testImplementation "commons-io:commons-io:${versions.commonsio}"
Expand Down
Loading
Loading