Skip to content

feat(tweaker): refine control editing and address clippy warnings#275

Open
Vladush wants to merge 9 commits intoEmixamPP:masterfrom
Vladush:feat/tweak-controls
Open

feat(tweaker): refine control editing and address clippy warnings#275
Vladush wants to merge 9 commits intoEmixamPP:masterfrom
Vladush:feat/tweak-controls

Conversation

@Vladush
Copy link

@Vladush Vladush commented Feb 22, 2026

  • Refactor byte-level editing and navigation for XuControls in the UVC Tweaker.
  • Add support for matches! macro and direct comparison to address cargo clippy warnings in src/configure/ui/tweaker.rs.
  • Improve doc comments for UI variants to be more readable.

@Vladush
Copy link
Author

Vladush commented Feb 22, 2026

Hi there!
I just wanted to share a bit of context for this PR.

I'm the author of linuxcampam, a project that heavily relies on linux-enable-ir-emitter to enable IR emitters for cameras to work with IR light.

I've made some attempts in the past to work around the tweaker configuration locally for my setup, but I decided it's much better to contribute these refinements back upstream! This PR adds better byte-level control editing to make the configuration process smoother, and I took the opportunity to clean up a few Clippy warnings (matches! macro, etc.) while I was at it.

Thanks for all your hard work on this tool! Let me know if there's anything else you need to get this merged.
Also, for hardware reference, I've tested these changes on my Lenovo Yoga Pro 7 (14ASP9) and it works great.

@EmixamPP
Copy link
Owner

Thank you very much for this consequent contribution! I'm really happy to get some help with this since I am quite busy (in my personal life) at the moment. It will try to regularly take a bit of time to progress on reviewing the code and merge this PR as quickly as possible! I wanted to tell you so as not to disrespect the time you invested in this PR.

@Vladush
Copy link
Author

Vladush commented Feb 25, 2026

Thanks for letting me know! 👍
I totally understand. I'll also be checking for your feedback and responding according to my time capacity. Take all the time you need! 🚀 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants