feat: add top text slots (topLeft/topRight) above health bar#281
Open
itsDNNS wants to merge 3 commits intoEllesmereGaming:mainfrom
Open
feat: add top text slots (topLeft/topRight) above health bar#281itsDNNS wants to merge 3 commits intoEllesmereGaming:mainfrom
itsDNNS wants to merge 3 commits intoEllesmereGaming:mainfrom
Conversation
Adds 2 new text positions above the health bar for each unit frame, increasing total text slots from 6 to 8: Health bar: leftText, rightText, centerText (existing) Top area: topLeftText, topRightText (NEW) Bottom bar: btbLeft, btbRight, btbCenter (existing) This enables more complex text layouts like ToxiUI-style arrangements where name, level, health %, health value, class icon, and power text are all visible simultaneously. New settings per unit (all default to "none"): - topLeftContent, topLeftSize, topLeftX, topLeftY, topLeftClassColor - topRightContent, topRightSize, topRightX, topRightY, topRightClassColor Options panel: dual dropdown row with cogwheel popups for size/offset/color. Modified: all 5 frame styles (Full, Focus, Simple, Pet, Boss), all 6 unit defaults, 4 refresh locations, options panel.
P2-1: Use btbTextValues for top text dropdowns (includes power tags) P2-2: Frame level +5 and 4px offset for top text overlay (avoids buff collision) P2-3: Width constraints when both top slots active (prevents text overlap)
…or offsets
P2: Top text overlay now at +26px above health (clears 22px buff icons + spacing)
P3: Width constraint accounts for X offsets (tlxo/trxo) to prevent overlap
when text is nudged toward center
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 2 new configurable text positions above the health bar, increasing total text slots from 6 to 8 per unit frame.
Closes #280
Changes
topLeftContent,topLeftSize,topLeftX/Y,topLeftClassColor(and matchingtopRight*) for all 6 unit types (player, target, totPet, pet, focus, boss)btbTextValues(includes power-based tags)Layout
All new slots default to
"none"(hidden), so existing profiles are unaffected.Test plan