Redesign Friends List: full skinning, class icons, custom groups#179
Draft
danvernon wants to merge 3 commits intoEllesmereGaming:mainfrom
Draft
Redesign Friends List: full skinning, class icons, custom groups#179danvernon wants to merge 3 commits intoEllesmereGaming:mainfrom
danvernon wants to merge 3 commits intoEllesmereGaming:mainfrom
Conversation
…and custom groups - Strip all Blizzard FriendsFrame chrome (NineSlice, portrait, title bar, inset, tab textures, scrollbar decorations, bottom button art) - Dark background with configurable opacity and pixel-perfect borders - Accent-colored underline on active tab via RegAccent integration - Class icons next to friend names with 8 icon style options (Blizzard atlas + 7 custom spritesheets: modern, pixel, glyph, arcade, legend, midnight, runic). Offline friends get desaturated icons. - Custom friend groups: create named groups, assign friends via right-click context menu, group tags displayed on friend rows - Alternating row backgrounds and hover highlights on friend buttons - Expanded options page with new sections: accent tab toggle, class icon controls, icon style dropdown, friend groups management (add/delete) - Full disable/enable support restores Blizzard defaults cleanly
danvernon
changed the title
danvernon
changed the title
…an up - Extract GetFriendInfo() helper — single API call per button instead of 3 separate calls to C_BattleNet/C_FriendList per button per update - Fix stale loop index in group delete closure: capture group name at render time, find by name at click time (prevents wrong-group deletion on rapid successive deletes before page refresh) - Lift context menu closures to module level (avoid per-open allocation) - Merge two ScrollBox.Update hooks into one - Hoist GetAccentColor() out of per-button loop - Cache class icon texture/position to skip redundant SetTexture/SetPoint - Remove unused globals (_EBS_GetFriendKey, _EBS_GetFriendDisplayName) - Use named constants for friend key prefixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Feedback from Ellesmere requesting an ElvUI-style Friends List overhaul — removing all Blizzard custom look, utilizing accent color, adding class icons next to names, and allowing custom friend grouping.
Test plan