Implement (experimental!) fetch of bolt11 invoices from (simple) offers#9168
Open
rustyrussell wants to merge 6 commits into
Open
Implement (experimental!) fetch of bolt11 invoices from (simple) offers#9168rustyrussell wants to merge 6 commits into
rustyrussell wants to merge 6 commits into
Conversation
…sts. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We hit this:
```
Bad invoice error {"code":-32602,"message":"Label 'c4f9d891047a770bb96953886ad9536cd4eb43f0dd4423dcd9a7b4952a615a8c-031f952d09872d0c45bfc81e3fb1d9c193647c176362f290f104c1d719547b044b-0' over 128 bytes"}
```
I'm not sure why it was there, but it's been there since the very early days.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…equested. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: Protocol: `offer` now sets the feature to allow experimental request of a bolt11 invoice, for simple offers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is the experimental proposal to allow bolt11 replies to fetchinvoice. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: JSON-RPC: `fetchinvoice` can fetch bolt11 invoices, if supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per spec draft at lightning/bolts#1336