refactor/type safe session#239
Open
2e0byo wants to merge 5 commits into
Open
Conversation
2e0byo
force-pushed
the
refactor/type-safe-session
branch
from
3a72934 to
5d4b769
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
._active_sessionattr type safe, i.e. gets rid of all the red underlines from your IDE telling you it might be None.This isn't IMHO the best way to handle this kind of state, but it's quick to do and should make the dev experience nicer. I could easily have done the others, I just wanted to show what it would look like. Open to thoughts.
[This PR is a superset of #238]