Allow to customize the default row action click trigger#7455
Merged
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom Mar 1, 2026
Merged
Conversation
af91562 to
7d4f15f
Compare
Collaborator
|
Thanks Nathan! While merging we did some minor tweaks. First, we moved all the code to the Crud class (and the Second, we did a minor method name change: -public function getDefaultRowActionClickTrigger(): string
+public function getDefaultRowActionTrigger(): stringBut these are minor changes. Most of your contribution was kept. Thanks! |
Contributor
Author
|
Thank you @javiereguiluz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @javiereguiluz
Thank you for implementing the default row action feature, this was something we have been looking forward to for a little while 😄
Unfortunately, it did break our current admins as we had an implementation in place which relies on double click instead of single one...
Here is a PR which allows to configure the "click trigger" for the default row action, it would be much appreciated if it can be release so we could get rid of our custom implementation and fix our admins for our users!
Thank you!