Skip to content

Allow to customize the default row action click trigger#7455

Merged
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom
natepage:feature/default-row-action-trigger-customization
Mar 1, 2026
Merged

Allow to customize the default row action click trigger#7455
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom
natepage:feature/default-row-action-trigger-customization

Conversation

@natepage
Copy link
Copy Markdown
Contributor

Hi @javiereguiluz

Thank you for implementing the default row action feature, this was something we have been looking forward to for a little while 😄
Unfortunately, it did break our current admins as we had an implementation in place which relies on double click instead of single one...

Here is a PR which allows to configure the "click trigger" for the default row action, it would be much appreciated if it can be release so we could get rid of our custom implementation and fix our admins for our users!

Thank you!

@javiereguiluz javiereguiluz added this to the 4.x milestone Mar 1, 2026
@javiereguiluz javiereguiluz force-pushed the feature/default-row-action-trigger-customization branch from af91562 to 7d4f15f Compare March 1, 2026 18:04
@javiereguiluz javiereguiluz merged commit 3557ae7 into EasyCorp:4.x Mar 1, 2026
18 checks passed
@javiereguiluz
Copy link
Copy Markdown
Collaborator

Thanks Nathan!

While merging we did some minor tweaks. First, we moved all the code to the Crud class (and the <table>) element from the EntityDto and the <tr> element because I think this belong to the CRUD config, not the entity.

Second, we did a minor method name change:

-public function getDefaultRowActionClickTrigger(): string
+public function getDefaultRowActionTrigger(): string

But these are minor changes. Most of your contribution was kept. Thanks!

@natepage
Copy link
Copy Markdown
Contributor Author

natepage commented Mar 2, 2026

Thank you @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants