10.07.18 first push#16
Open
GeorgeTsendra wants to merge 2 commits intomasterfrom
Open
Conversation
OlegLustenko
requested changes
Jul 11, 2018
| //формируем ID по длине массива + 1 | ||
| let correctId = this.dataBase.length+1; | ||
|
|
||
| this.dataBase.push({id:correctId,name:name,thername:thername,numb:`(${firstThreeNumb})${secondTwoNumb}-${therdTwoNumb}-${fourthThreeNumb}`}) |
Member
There was a problem hiding this comment.
тут оччень длинная строка, предлагаю сделать отдельный конструктор для создания пользователя
| PhoneApp.prototype.usersRemoving = function(username) { | ||
| this.dataBase.forEach((value, index, arr)=> { | ||
| if (value.name === username) { | ||
| delete this.dataBase[index]; |
Member
There was a problem hiding this comment.
будет дыра в массиве,
использования метода .filter - тут подойдет лучше
|
|
||
| PhoneApp.prototype.searchUsers = function(username) { | ||
| let allUsers = []; | ||
| this.dataBase.forEach((value, index, arr)=> { |
Member
There was a problem hiding this comment.
тоже подойдет лучше метод filter
| this.dataBase.forEach((value, index, arr)=> { | ||
| let correctId = index + 1; | ||
| if (value.id == userId) { | ||
| this.dataBase[index] = {id:correctId,name:name,thername:thername,numb:`(${firstThreeNumb})${secondTwoNumb}-${therdTwoNumb}-${fourthThreeNumb}`}; |
Member
There was a problem hiding this comment.
{id:correctId,name:name,thername:thername,numb:`(${firstThreeNumb})${secondTwoNumb}-${therdTwoNumb}-${fourthThreeNumb}`};это очень длинная строка, легче это называть в духе "makeUser" или что то такое
она даже не очень помещается в экран
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.