remove shader bounds

[TheJeran]

This is the first step for #592 by removing all of the bound logic from components and shaders.

Additionally, I was using DoubleSide render for the instances and points-clouds for some reason. So I removed that back to default (Frontside) and that gave a very notable performance improvement to the instanced plots. Points are still not ideal.
I also added NoBlending to instanced materials in case that helps with performance and added depth testing as I now understand better whats happening and that helps performance.

Lastly, I solved #609 by ensuring that the texture array fed into the shaders is always an array of length 14 and that seems to have handled the issue with changing array sizes

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on significant performance optimizations and bug fixes related to shader and rendering logic. By removing deprecated bound calculations and adjusting rendering properties like blending and side rendering, the application achieves improved frame rates, particularly for instanced plots. Additionally, a critical bug affecting texture array handling in shaders has been addressed, ensuring stability and correct rendering across different data configurations.

Highlights

• Shader Optimization: Removed unnecessary bound logic from various components and shaders, streamlining rendering processes and reducing overhead.
• Performance Improvements: Switched instanced plots and point clouds from DoubleSide rendering to default FrontSide, and applied NoBlending and depthTest to instanced materials, leading to notable performance gains.
• Texture Array Fix: Implemented a solution for issue If Texture array length changes, causes GL Compiler issue #609 by ensuring that texture arrays passed to shaders consistently have a length of 14, resolving issues with changing array sizes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors several plot components and their associated GLSL shaders. Key changes include standardizing texture array initialization across DataCube, FlatMap, and Sphere components, simplifying blending and depth settings in FlatBlocks, PointCloud, and SphereBlocks by moving to THREE.NoBlending and explicitly setting depthTest: true, and removing extensive time series selection and highlighting logic from FlatMap, PointCloud, and Sphere components and their shaders. The review feedback suggests extracting the repeated texture array creation logic into a shared utility function to adhere to the DRY principle and improve maintainability.

[gemini-code-assist]

This logic to create a fixed-size texture array is repeated in FlatMap.tsx and Sphere.tsx. To adhere to the DRY (Don't Repeat Yourself) principle, consider extracting this into a utility function in src/utils/HelperFuncs.ts.

For example:

// in src/utils/HelperFuncs.ts
export function createFixedTextureArray(textures: THREE.Texture[] | null, length: number = 14): (THREE.Texture | undefined)[] {
    return Array.from({ length }, (_, idx) => textures?.[idx]);
}

You could then use it here and in the other components like this:

map: { value: createFixedTextureArray(volTexture) },

This would improve code reuse and maintainability.